Craft XP Bug

[justj99]

FT Account name: justj99
Time of bug: Anytime an item is crafted
Where: Calculation of craft xp
What: Craft skill increase is deducted twice
Why: Craft xp is not given in accordance with the manual
Other comments:
According to the manual, craft XP is given per the following:

For crafting you get XP every time you fail. The formula is:

XP = 1000 - 10 * craft_chance

For example for crafting planks you have chance 70% so every time you fail you get 1000 - 700 = 300 XP.

Each level in crafting gives you +3% * Trade affinity craft chance.

The formula is only working this way while craft level is 0. This is because it seems to actually be calculated by:
XP = 1000 - 10 * (craft_chance + (craft_level * affinity))

At level 0, that is fine. At level 1, less XP is gained. This would be fine if craft_chance was the item list craft_chance. It is not, however. The craft chance being used is the player's craft chance for that item, not the item list craft chance for that item.

Using the same example of craft XP for the manual at level 1 with affinity 1 should be:
Plank craft_chance = 70% + 3% for craft level = 73%. So, at level 1, craft XP should be:
XP = 1000 - 700 - 30 = 270.
What we actually get is:
XP = 1000 - 730 - 30 = 240.

So, player craft skill gets subtracted twice. This is not what the manual formula says. Either the code should be corrected, or the manual should be updated.

[justj99]

This one annoys me very much. Sorry to bring it up again. I don't think it was submitted as a bug previously.

[LostKnight]

Two Thumbs UP for this

Fix the code! being penalized twice is not good.

[Leone]

I know we spoke about this ingame justj99 and now it is late for me. I think blitzcraig discussed this on the forum and you already mentioned a kromelg post.

I think there is some clarification.

We will find it:)

[SK1976]

as i remenber at a special level on wood cutting u not get any xps from crafting planks

[justj99]

I found this old bug post about craft xp with help from Leone. I'm not quite sure I get the formula speculated there, but it seems to work for the numbers he posted at least.

viewtopic.php?f=6&t=16274

I was asked to be more clear, so here goes:

In the item.list, a plank has a craft chance of 70%, gold plate has a craft chance of 0.5%.

Per the manual, the chance to craft is the item chance plus craft level x 3 x affinity. For all examples, I'll use affinity of 1 to simplify the math, so increase to chance to craft is 3% increase per craft level. So, 3 x craft level.

At level 0, the skill increase is 3 x 0 = 0% improvement . Chance to craft matches the items.list number, and craft xp matches the manual:
Plank xp fail = 1000 - (10 x (70 + (0 x 3%)) = 300 xp
Gold plate = 1000 - (10 x (0.5 + (0 x 3%)) = 995 xp

Starting with level 1, craft xp per fail no longer matches up with the manual. It should be:
Plank xp = 1000 - (10 x (70 + (level 1 x 3%))
= 1000 - 730 = 270 xp
Gold plate = 1000 - (10 x (0.5 + (1 x 3%))
= 1000 - 35 = 965 xp

Instead, for level 1 we get:
Plank xp = 240
Gold Plate xp = 935

So, the improvement from craft affinity is being deducted twice. Once for my improved chance to succeed (correct), but then again for an unknown reason. I feel like the second deduction should not be.

Otherwise, I will eventually be able to gain no experience from craft fails. When my craft level and affinity lead to my improved chance to succeed being 50%, I will no longer gain craft xp for any fail.

In theory, my chance to succeed with gold plate would be 50.5%, but a fail would get me 0 craft xp.

1000 - (10 x (0.5 + 50)) should get me 450 xp , but another 50% will be deducted, so I will get 0 points.

If this is indeed the intention, then I don't quite understand the rationale, but that's ok. The manual should probably be updated to explain this a little better, but at least the forum can say that it is actually intentional here.

[SellSword]

viewtopic.php?f=4&t=16932&p=114778&hilit=Craft#p114778

That's the kromelg post that is mentioned. To the best of my knowledge that is the last clarification, or at least made by someone on the GM team.

[justj99]

Yes, he's stating what is still the current behavior. I still question if this is a bug due to his last statement in that post...

"But I dont know when and why it was changed."

[SK1976]

i m waiting for explaining by compbatant ......

[justj99]

Looking for quest bugs to recommend fixing, but this one still makes me crabby!